Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Inconsistent Page Display for Invalid URLs on User Pages #252

Closed
1 task done
Saurav-Pant opened this issue Jun 4, 2023 · 3 comments
Closed
1 task done

[Feat]: Inconsistent Page Display for Invalid URLs on User Pages #252

Saurav-Pant opened this issue Jun 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Saurav-Pant
Copy link

What feature?

When entering an incorrect URL on user pages, the website displays the same content instead of redirecting to a proper error page, leading to confusion and a poor user experience.

Add screenshots

pnf.mp4

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Saurav-Pant Saurav-Pant added the enhancement New feature or request label Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Welcome, @Saurav-Pant! Your issue is like a spark that ignites innovation. We're thrilled to dive into it and work together to find a solution.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@Yair-N
Copy link
Contributor

Yair-N commented Jun 4, 2023

Hey, I can take care of this. I have a solution ready

Yair-N pushed a commit to Yair-N/devFind that referenced this issue Jun 4, 2023
@YairNotkovich
working on shyamtawli#252
b24d83f
Yair-N pushed a commit to Yair-N/devFind that referenced this issue Jun 4, 2023
@YairNotkovich
fix issue shyamtawli#252
d0f6ea2
@Yair-N Yair-N mentioned this issue Jun 4, 2023
Merged
@Yair-N
Copy link
Contributor

Yair-N commented Jun 4, 2023

Now that i think about it, my solution might be in conflict with a solution for issue #220.
I avoided adding additional libraries such as 'react-router-dom' but issue #220 would require some sort of routing.
Maybe it could be a good stage to migrate the project to Next 13 and use its pages and layouts features?

any way I would be happy to help on any issue

shyamtawli added a commit that referenced this issue Jun 5, 2023
@Yair-N @YairNotkovich @shyamtawli
Error Page Component added (#255)
28d931b 
* working on #252

* fix issue #252

---------

Co-authored-by: Yair <[email protected]>
Co-authored-by: Shyam Tawli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Saurav-Pant @shyamtawli @Yair-N