Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Page Component added #255

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Error Page Component added #255

merged 4 commits into from
Jun 5, 2023

Conversation

Yair-N
Copy link
Contributor

@Yair-N Yair-N commented Jun 4, 2023

Description

Intercepts any wrong URL and renders a 404 page instead of the profile cards

Related Issues

Fixes issue #252

Changes Proposed

added ErrorPage component

Checklist

  • [ V] I have read and followed the [Contribution Guidelines]

@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 11:58am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Yair-N! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli shyamtawli changed the title Yair n Error Page Component added Jun 5, 2023
@shyamtawli shyamtawli added the enhancement New feature or request label Jun 5, 2023
@Yair-N
Copy link
Contributor Author

Yair-N commented Jun 5, 2023

Thanks, anything else I can work on?

@shyamtawli
Copy link
Owner

@Yair-N Thank you again for the contribution. You can look into issues section or try to find your own issue and you can work on it.

@shyamtawli shyamtawli merged commit 28d931b into shyamtawli:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants