Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): impl RuntimeConfigModel #10035

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 8, 2025

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Feb 8, 2025
Copy link
Member Author

fengmk2 commented Feb 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 7c80c35 to e92a1c5 Compare February 8, 2025 06:00
@fengmk2 fengmk2 requested a review from forehalo February 8, 2025 06:01
@fengmk2 fengmk2 marked this pull request as ready for review February 8, 2025 06:01
@graphite-app graphite-app bot requested review from a team February 8, 2025 06:01
@fengmk2 fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from e92a1c5 to 14064ca Compare February 8, 2025 06:03
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.02%. Comparing base (631c8b8) to head (8a49bc4).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10035      +/-   ##
==========================================
+ Coverage   53.96%   54.02%   +0.06%     
==========================================
  Files        2322     2323       +1     
  Lines      106989   107064      +75     
  Branches    17734    17736       +2     
==========================================
+ Hits        57735    57843     +108     
+ Misses      47920    47892      -28     
+ Partials     1334     1329       -5     
Flag Coverage Δ
server-test 78.34% <100.00%> (+0.04%) ⬆️
unittest 31.36% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch 5 times, most recently from a3c58bd to 88c9ebc Compare February 13, 2025 15:34
@fengmk2 fengmk2 marked this pull request as draft February 13, 2025 15:48
@fengmk2 fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 88c9ebc to 309176f Compare February 14, 2025 02:56
@fengmk2 fengmk2 marked this pull request as ready for review February 14, 2025 02:57
@fengmk2 fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 309176f to 8a49bc4 Compare February 14, 2025 15:30
@fengmk2 fengmk2 marked this pull request as draft February 20, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant