refactor(server): use RuntimeConfigModel on Runtime service #10036

fengmk2 · 2025-02-08T06:00:11Z

move runtime from base to core

fengmk2 · 2025-02-08T06:00:27Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

refactor(server): use RuntimeConfigModel on Runtime service #10036 👈 (View in Graphite)
feat(server): impl RuntimeConfigModel #10035
canary

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-02-08T06:11:49Z

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.99%. Comparing base (8a49bc4) to head (67b19c7).

Files with missing lines	Patch %	Lines
...ackages/backend/server/src/core/runtime/service.ts	87.09%	4 Missing ⚠️

Additional details and impacted files

@@                              Coverage Diff                              @@
##           02-08-feat_server_impl_runtimeconfigmodel   #10036      +/-   ##
=============================================================================
- Coverage                                      54.02%   53.99%   -0.03%     
=============================================================================
  Files                                           2323     2323              
  Lines                                         107064   107008      -56     
  Branches                                       17736    17734       -2     
=============================================================================
- Hits                                           57843    57782      -61     
- Misses                                         47892    47897       +5     
  Partials                                        1329     1329

Flag	Coverage Δ
server-test	`78.30% <93.10%> (-0.05%)`	⬇️
unittest	`31.36% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/backend/server/src/base/runtime/service.ts

close CLOUD-120

forehalo · 2025-02-20T07:25:43Z

packages/backend/server/src/models/common/page.ts

  Page,
  Edgeless,
 }
+
+export enum WorkspaceRole {


keep the pr clean

ok, I will rewrite it after 0.20 released.

forehalo · 2025-02-20T07:31:45Z

packages/backend/server/src/core/runtime/event.ts

@@ -1,4 +1,4 @@
-import { FlattenedAppRuntimeConfig } from '../config/types';
+import { FlattenedAppRuntimeConfig } from '../../base/config/types';

 declare global {
  interface Events {


[Re: line +5]

time to impl it.

'runtime.init'
'runtime.changed'

instances can keep runtime config in memory to avoid read it every time used. or adjust the runtime when value changed

@OnEvent('runtime.changed') updateConcurrency(changes: Partial<Runtime>) { if (changes['job/worker.concurrency']) { this.worker.concurrency = changes['job/worker.concurrency'] } }

See this comment inline on Graphite.

forehalo · 2025-02-20T07:33:14Z

packages/backend/server/src/core/runtime/service.ts

-        deletedAt: null,
-      },
-    });
+    const existingConfigs = await this.models.runtimeConfig.findManyByModule();


move it to always run data migration

and there was a bug regarding this. when beta introduces a new config, and stable got redeployed, the new one will be marked deleted and cause beta down

forehalo · 2025-02-20T07:34:11Z

packages/backend/server/src/core/runtime/service.ts

-        value: value as any,
-        deletedAt: null,
-      },
+    const config = await this.models.runtimeConfig.upsert(key, {


we need a way to define validator on values. basic type validator for String/Number/Boolean, or custom like Semver.valid for versioning checks

github-actions bot added app:server test Related to test cases labels Feb 8, 2025

fengmk2 mentioned this pull request Feb 8, 2025

feat(server): impl RuntimeConfigModel #10035

Draft

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 7c80c35 to e92a1c5 Compare February 8, 2025 06:00

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from 8e761a8 to 87450be Compare February 8, 2025 06:00

fengmk2 requested a review from forehalo February 8, 2025 06:01

fengmk2 marked this pull request as ready for review February 8, 2025 06:01

graphite-app bot requested review from a team February 8, 2025 06:01

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from 87450be to 7070771 Compare February 8, 2025 06:03

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from e92a1c5 to 14064ca Compare February 8, 2025 06:03

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 14064ca to 470d695 Compare February 10, 2025 08:54

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from 7070771 to f34cea6 Compare February 10, 2025 08:54

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 470d695 to 841df8c Compare February 10, 2025 10:54

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch 2 times, most recently from 7f53769 to f712fe0 Compare February 10, 2025 13:08

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 841df8c to 886fa35 Compare February 10, 2025 13:08

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from f712fe0 to 879dc03 Compare February 12, 2025 02:01

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 886fa35 to a3c58bd Compare February 12, 2025 02:01

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from 879dc03 to cb2a226 Compare February 13, 2025 15:34

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from a3c58bd to 88c9ebc Compare February 13, 2025 15:34

fengmk2 commented Feb 13, 2025

View reviewed changes

packages/backend/server/src/base/runtime/service.ts Show resolved Hide resolved

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 88c9ebc to 309176f Compare February 14, 2025 02:56

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch 4 times, most recently from af99810 to 0505384 Compare February 14, 2025 04:33

refactor(server): use RuntimeConfigModel on Runtime service

67b19c7

close CLOUD-120

fengmk2 force-pushed the 02-08-feat_server_impl_runtimeconfigmodel branch from 309176f to 8a49bc4 Compare February 14, 2025 15:30

fengmk2 force-pushed the 02-08-refactor_server_use_runtimeconfigmodel_on_runtime_service branch from 0505384 to 67b19c7 Compare February 14, 2025 15:30

forehalo reviewed Feb 20, 2025

View reviewed changes

fengmk2 marked this pull request as draft February 20, 2025 07:28

forehalo reviewed Feb 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(server): use RuntimeConfigModel on Runtime service #10036

refactor(server): use RuntimeConfigModel on Runtime service #10036

fengmk2 commented Feb 8, 2025 •

edited

Loading

fengmk2 commented Feb 8, 2025

codecov bot commented Feb 8, 2025 •

edited

Loading

forehalo Feb 20, 2025

fengmk2 Feb 20, 2025

forehalo Feb 20, 2025

forehalo Feb 20, 2025

forehalo Feb 20, 2025

forehalo Feb 20, 2025 •

edited

Loading

refactor(server): use RuntimeConfigModel on Runtime service #10036

Are you sure you want to change the base?

refactor(server): use RuntimeConfigModel on Runtime service #10036

Conversation

fengmk2 commented Feb 8, 2025 • edited Loading

fengmk2 commented Feb 8, 2025

How to use the Graphite Merge Queue

codecov bot commented Feb 8, 2025 • edited Loading

Codecov Report

forehalo Feb 20, 2025

Choose a reason for hiding this comment

fengmk2 Feb 20, 2025

Choose a reason for hiding this comment

forehalo Feb 20, 2025

Choose a reason for hiding this comment

forehalo Feb 20, 2025

Choose a reason for hiding this comment

forehalo Feb 20, 2025

Choose a reason for hiding this comment

forehalo Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

fengmk2 commented Feb 8, 2025 •

edited

Loading

codecov bot commented Feb 8, 2025 •

edited

Loading

forehalo Feb 20, 2025 •

edited

Loading