Unique keyword arg

[cosmicBboy]

fixes #390

@fkrull8 I'm re-opening a pull request against the current master branch and will work on getting this merged

[cosmicBboy]

hey @fkrull8 would you mind giving me push access to your fork of pandera? https://github.com/fkrull8/pandera

Just fixed all the merge conflicts mentioned above.

[abyz0123]

Hi @cosmicBboy , apologies for not seeing this earlier! I think I should have just provided you with collaborator access to the repo. The PR was only half finished, as I was having trouble with the property assignment of the new unique keyword in the base class. The tests that I had written should have failed where I was having trouble. If I could get an assist on that, I could pick this PR back up and iron it out.

[cosmicBboy]

no worries @fkrull8, and thanks for the write permissions! I'll iron out some of the tests and hand it back over to you

[codecov]

Codecov Report

Merging #580 (9bcce4f) into master (3191be9) will decrease coverage by 0.67%.
The diff coverage is 98.35%.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   99.45%   98.77%   -0.68%     
==========================================
  Files          21       29       +8     
  Lines        2572     3359     +787     
==========================================
+ Hits         2558     3318     +760     
- Misses         14       41      +27     

Impacted Files	Coverage Δ
pandera/hypotheses.py	94.54% <ø> (ø)
pandera/schema_inference.py	100.00% <ø> (ø)
pandera/error_formatters.py	95.45% <75.00%> (-4.55%)	⬇️
pandera/dtypes.py	92.38% <92.34%> (-7.62%)	⬇️
pandera/strategies.py	97.71% <97.22%> (-2.29%)	⬇️
pandera/schemas.py	99.47% <98.75%> (+0.16%)	⬆️
pandera/engines/engine.py	98.82% <98.82%> (ø)
pandera/engines/pandas_engine.py	99.29% <99.29%> (ø)
pandera/__init__.py	100.00% <100.00%> (ø)
pandera/check_utils.py	100.00% <100.00%> (ø)
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3191be9...9bcce4f. Read the comment docs.

[rbngz]

Hello

Thank you for this PR. This functionality is exactly what we need.
Would you maybe also be able to integrate these changes into the FrictionlessFieldParser in order to fix #587 ?

[cosmicBboy]

hey @rbngz yes! this PR is almost ready.

@fkrull8 I managed to iron out a bunch of the tests since revamping the type system... I might be missing something, but this PR seems to be feature complete?

The only thing blocking is adding test coverage for these non-covered lines of code: https://github.com/pandera-dev/pandera/pull/580/checks?check_run_id=3281386477

@rbngz once this PR is merged would you be open to making a contribution to add support for multi-column uniqueness in FrictionlessFieldParser?

[abyz0123]

Hi @cosmicBboy, apologies for the late follow-up on this. Yes! The issues I was having before seem to have been ironed out. The feature that is not covered with this PR is the on the hypothesis side. As far as I can tell, there is no ready-made methods from hypothesis for setting unique-ness over multiple columns. That would have to be custom-made.

[abyz0123]

I have to admit I'm a bit mystified by the coverage results -- the uncovered bits don't appear to be different than on master branch. The uncovered cases from #580 (comment) have been addressed with dc88f59 .

Sorry about the earlier linting errors, my dev environment wasnt set up properly for tox.

[cosmicBboy]

I have to admit I'm a bit mystified by the coverage results

yeah coverage results can be a little finicky.

[cosmicBboy]

@fkrull8 going to merge this now, thanks and congratulations on your first contribution to pandera 🎉