-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5564: setup compiler-building github action [skip ci] #2592
Conversation
6c0ff7c
to
0a05cfc
Compare
0a05cfc
to
b7be188
Compare
cc @Jens-G i guess this needs to be enabled after the merge - for now i can't see from the actions tab whether it's working or not |
You should be able to see if it's working in your fork. |
thanks for the pointer - it's https://github.com/Jimexist/thrift/actions/runs/2237581561 and working for now |
with that passed i plan to leave this pull request as is and put future work in subsequent pull requests to make the change / shift incremental. my current plan is to have several steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only partially accomplishes the task described in the JIRA. But, I think that's okay, because you need the GitHub Actions to be enabled, which this will do, in order to validate future changes that are more complex. However, this needs to run on PRs as well as push, in order to be useful.
@ctubbsii thanks for the review - i guess it's turned on now 🏁 |
ea017fd
to
09428f7
Compare
setup a basic github action. this is part of THRIFT-5564 but does not completely close it yet.
[skip ci]
anywhere in the commit message to free up build resources.