Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5575: add a github workflow to invoke cmake #2595

Merged
merged 6 commits into from
May 21, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Apr 29, 2022

see also:

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title add a github workflow to invoke cmake THRIFT-5575: add a github workflow to invoke cmake Apr 29, 2022
@emmenlau
Copy link
Member

Hi @jimexist ! I just wanted to point out that we have a work-in-progress PR for dotnet support in cmake. Its not really using the dotnet-capabilities of cmake, but rather cmake is creating build instructions that under the hood will call dotnet for the build. That's quite in line with what automake was doing, just from cmake. I can update my PR and push it again if you want me to?

@jimexist
Copy link
Member Author

Hi @jimexist ! I just wanted to point out that we have a work-in-progress PR for dotnet support in cmake. Its not really using the dotnet-capabilities of cmake, but rather cmake is creating build instructions that under the hood will call dotnet for the build. That's quite in line with what automake was doing, just from cmake. I can update my PR and push it again if you want me to?

@emmenlau thanks for the info, please feel free to.

currently i have not yet added library building part into this pull request so it only builds and tests the compiler - the library building part will be added later (possibly not by me). i'm currently mostly focusing on bring up the autoconf part where the approach is split and conquer instead of the original monolithic approach (of preparing all env for all langs).

@ctubbsii
Copy link
Member

These changes are CI only, and everything's still passing, so I see no reason not to merge this.

@ctubbsii ctubbsii merged commit c6f18a5 into apache:master May 21, 2022
@jimexist jimexist deleted the add-cmake-workflow branch May 21, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants