-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5575: add a github workflow to invoke cmake #2595
Conversation
Hi @jimexist ! I just wanted to point out that we have a work-in-progress PR for dotnet support in cmake. Its not really using the dotnet-capabilities of cmake, but rather cmake is creating build instructions that under the hood will call dotnet for the build. That's quite in line with what automake was doing, just from cmake. I can update my PR and push it again if you want me to? |
@emmenlau thanks for the info, please feel free to. currently i have not yet added library building part into this pull request so it only builds and tests the compiler - the library building part will be added later (possibly not by me). i'm currently mostly focusing on bring up the autoconf part where the approach is split and conquer instead of the original monolithic approach (of preparing all env for all langs). |
These changes are CI only, and everything's still passing, so I see no reason not to merge this. |
see also:
[skip ci]
anywhere in the commit message to free up build resources.