-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5564: setup java and kotlin lib building #2593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved the merge conflicts, but feel free to rebase yourself.
I'm noticing the job name is quite long, which makes it hard to see the matrix params in the PR display. You can probably shorten it from "Build Thrift Compiler and Libraries" to just "Build" or similar. You can also reduce the number of items in the matrix, and the output, by not making the Java distribution a matrix. It's probably sufficient to just use a single stable Java distribution. If temurin works, then just use that, but don't need to put it in the matrix. You can also probably remove the Java 8 builds, since Java 11 should be using |
for now we can't because we are on gradle 6.9; we'll have to upgrade to gradle 7 first but that in turn replies on migrating from |
Just want to drop the usual reminder of maintaining the ReleaseManagement.md because we will need this. |
thanks for the reminder @Jens-G, for now this and the currently open pull requests only adds CI part, not the CD part, also the travis CI is intact - so I have no changes to the |
setup java and kotlin lib building
this is a second step after:
[skip ci]
anywhere in the commit message to free up build resources.